Better help organization for --querytags and --queryinfo
#1627
Conversation
| @@ -435,7 +435,6 @@ def _add_add_remote_packages(self): | |||
|
|
|||
| def run(self): | |||
| if self.opts.querytags: | |||
| print(_('Available query-tags: use --queryformat ".. %{tag} .."')) | |||
There was a problem hiding this comment.
Also if you wanna do this, could you also remove at least the leading line-break (and ideally the trailing one too) from the QUERY_TAGS variable? Now it prints an empty line before and after the list of tags which are superfluous.
There was a problem hiding this comment.
Removed spaces. Although I would also split reponame (repoid) into separate items, or removed reponame completely. Then it will be relatively easy to parse the output with something like bash.
There was a problem hiding this comment.
It appears reponame doesn't stand for the name, it's the id, same as repoid. An obvious error? I'm not against just removing it, but I'm not sure we can do that. I'm sure @j-mracek will know more though?
There was a problem hiding this comment.
I am sorry, but I do not understanding your question. Reponame as an attribute of package class. --qf is capable to return any attribute of Package class.
.. attribute:: reponame
Id of repository the package was installed from (string).
There was a problem hiding this comment.
I am sorry, but I do not understanding your question. Reponame as an attribute of package class. --qf is capable to return any attribute of Package class.
The question is whether we should remove reponame from the list, because it contains the ID, not the name. And since there already is repoid, it is redundant in addition to wrong.
.. attribute:: reponame Id of repository the package was installed from (string).
I'd assume this is some sort of legacy API attribute, since it's called "name" and contains the ID. FTR the excerpt is from the API documentation: https://github.com/rpm-software-management/dnf/blob/master/doc/api_package.rst. Interestingly repoid isn't listed there and also no way to get the actual repo name.
There was a problem hiding this comment.
I don't see any benefit in removal of print(_('Available query-tags: use --queryformat ".. %{tag} .."'))
There was a problem hiding this comment.
@j-mracek it is to make the output suitable for scripting. For example https://github.com/rpm-software-management/libdnf/issues/720#issuecomment-631625069
There was a problem hiding this comment.
Although I'm not entirely sure what would you parse the list for (ultimately you have to know the semantics of each field so you need to have them listed somewhere in your code anyway), I find it reasonable to remove it...
|
Sorting options automatically is hard when subgroups are involved as in this case. ) |
Bring commands next to each other and make --querytags output machine readable.
|
@j-mracek this is stuck on your input so I'll reassign it to you. If you'd be fine with the changes and just want me to finish this up, feel free to assign back to me. Thanks. |
|
📌 Commit c1aedfe has been approved by |
Bring commands next to each other and make --querytags output machine readable. Closes: #1627 Approved by: j-mracek
|
☀️ Test successful - status-papr |
|
👀 Test was successful, but fast-forwarding failed: 422 Update is not a fast forward |
|
I've opened https://bugzilla.redhat.com/show_bug.cgi?id=1851125 for dealing with the |
This makes help output self-sufficient, and removes extra doc form
--querytagsoutput making it possible to parse the output with scripts (rpm-software-management/dnf5#1243)New help output.